Skip to content

fix: minor improvements in jinja auto escape and subprocess call #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2025
Merged

fix: minor improvements in jinja auto escape and subprocess call #754

merged 3 commits into from
Jul 18, 2025

Conversation

@Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Jul 17, 2025 •
edited
Loading

No description provided.

@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner July 17, 2025 10:13
@github-actions github-actions bot added the fix Pull requests related to resolving problems or errors label Jul 17, 2025
@Revathyvenugopal162 Revathyvenugopal162 added this to the v1.6 milestone Jul 17, 2025
RobPasMue
RobPasMue reviewed Jul 17, 2025
View reviewed changes
@MaxJPRey
Copy link
Contributor

MaxJPRey commented Jul 18, 2025 •
edited
Loading

LGTM, could you just explain why the autoescape feature?

@Revathyvenugopal162
Copy link
Contributor Author

Revathyvenugopal162 commented Jul 18, 2025

LGTM, could you just explain why the autoescape feature?

By default, Jinja2 does not enable auto-escaping, which means HTML content passed through template variables is not automatically escaped unless explicitly configured. Enabling auto-escaping ensures that input strings are safely filtered before rendering.

RobPasMue
RobPasMue approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Revathyvenugopal162 Revathyvenugopal162 merged commit 2144ab9 into main Jul 18, 2025
19 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/subprocess branch July 18, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

Assignees

No one assigned

Labels

fix Pull requests related to resolving problems or errors

Projects

None yet

Milestone

v1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@Revathyvenugopal162 @MaxJPRey @RobPasMue @pyansys-ci-bot